Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcbuild explodes is Python is not installed #16864

Closed
seishun opened this issue Nov 7, 2017 · 1 comment
Closed

vcbuild explodes is Python is not installed #16864

seishun opened this issue Nov 7, 2017 · 1 comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@seishun
Copy link
Contributor

seishun commented Nov 7, 2017 •
edited
Loading

  • Version: master
  • Platform: Windows 7
  • Subsystem: build

If Python is not installed on the system, vcbuild prints out the following and creates a "Windows can't open this file" dialog

ERROR: The system was unable to find the specified registry key or value.
ERROR: The system was unable to find the specified registry key or value.
Cannot determine current version of Node.js

cc @refack
@seishun seishun added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Nov 7, 2017
@addaleax
Copy link
Member

addaleax commented Nov 7, 2017

There was a similar issue at yesterday’s code & learn, giving trouble when only Python 3 is installed I think?

/cc @hxlnt (assuming you might want to be cc’ed on these kinds of issues?)

@bzoz bzoz mentioned this issue Nov 14, 2017
Closed
2 tasks
@seishun seishun mentioned this issue Nov 25, 2017
Closed
2 tasks
@refack refack mentioned this issue Nov 25, 2017
Closed
3 tasks
@seishun seishun mentioned this issue Feb 13, 2018
Closed
bzoz added a commit to JaneaSystems/node that referenced this issue Feb 15, 2018
@bzoz
build, win: vcbuild improvements
766aa49 
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.

Fixes: nodejs#16864
@bzoz bzoz closed this as completed in 887a2ba Feb 22, 2018
addaleax pushed a commit to addaleax/node that referenced this issue Feb 26, 2018
@bzoz @addaleax
build, win: vcbuild improvements
04f0482 
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.

Fixes: nodejs#16864

PR-URL: nodejs#17015
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this issue Feb 26, 2018
@bzoz @addaleax
build, win: vcbuild improvements
16ef386 
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.

Fixes: #16864

PR-URL: #17015
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@bzoz @MayaLekova
build, win: vcbuild improvements
e66ff5e 
Removes extra erroor messages when Python is not installed. Removes
"vswhere not found" message when no VS2017 installation is found.
Adds support for DEBUG_HELPER to vcbuild.bat.

Fixes: nodejs#16864

PR-URL: nodejs#17015
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
2 participants
@addaleax @seishun