Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's the deal with benchmark/misc/v8-bench.js? #16119

Closed
Trott opened this issue Oct 10, 2017 · 4 comments
Closed

What's the deal with benchmark/misc/v8-bench.js? #16119

Trott opened this issue Oct 10, 2017 · 4 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. question Issues that look for answers. v8 engine Issues and PRs related to the V8 dependency.

Comments

@Trott
Copy link
Member

Trott commented Oct 10, 2017

  • Version: current master branch
  • Platform: n/a
  • Subsystem: benchmark

What's the deal with benchmark/misc/v8-bench.js? It does not behave like our other benchmark files. Should it live somewhere else? Should it be deleted?

@nodejs/benchmarking @mscdex
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. question Issues that look for answers. v8 engine Issues and PRs related to the V8 dependency. labels Oct 10, 2017
@joyeecheung
Copy link
Member

joyeecheung commented Oct 10, 2017 •
edited
Loading

I think this is supposed to be used like this:

  1. Run ./node benchmark/misc/v8-bench.js
  2. Open deps/v8/benchmarks/run.html
  3. Compare the scores of the V8 in Node.js and the V8 in your browser.

I tried to run these V8 benchmarks a few times and the results are pretty flaky. Also the way it's written, it doesn't work with our benchmark suites(run.js, etc.). There seems to be a merit in keeping it though.

@hashseed
Copy link
Member

V8 bench is very outdated and has been replaced by Octane years ago.

What is the goal of this benchmark? To ensure that Node.js is on par with Chrome?

@bnoordhuis
Copy link
Member

Yes, it was added as a quick gauge.

It can be removed, IMO. We started benchmarking Octane in nodejs/benchmarking#79.

@joyeecheung joyeecheung mentioned this issue Oct 10, 2017
Closed
3 tasks
joyeecheung added a commit that referenced this issue Oct 11, 2017
@joyeecheung
benchmark: remove misc/v8-bench.js
5dbd32c 
These v8 benchmarks are oudated and have been replaced by
Octane in the upstream. The benchmarking working group
has already been benchmarking Octane, so this file
can be removed now.

PR-URL: #16126
Ref: #16119
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this issue Oct 12, 2017
@joyeecheung @addaleax
benchmark: remove misc/v8-bench.js
ab59637 
These v8 benchmarks are oudated and have been replaced by
Octane in the upstream. The benchmarking working group
has already been benchmarking Octane, so this file
can be removed now.

PR-URL: nodejs/node#16126
Ref: nodejs/node#16119
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@joyeecheung
Copy link
Member

It's been removed in #16126, so closing

targos pushed a commit that referenced this issue Oct 18, 2017
@joyeecheung @targos
benchmark: remove misc/v8-bench.js
dc48e9c 
These v8 benchmarks are oudated and have been replaced by
Octane in the upstream. The benchmarking working group
has already been benchmarking Octane, so this file
can be removed now.

PR-URL: #16126
Ref: #16119
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. question Issues that look for answers. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bnoordhuis @Trott @hashseed @joyeecheung