Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixtures module returning absolute paths causes test failures in Windows with 'x' or 'u' in path after delimiter #16057

Closed
vsemozhetbyt opened this issue Oct 6, 2017 · 0 comments
Closed

test: fixtures module returning absolute paths causes test failures in Windows with 'x' or 'u' in path after delimiter #16057

vsemozhetbyt opened this issue Oct 6, 2017 · 0 comments
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 6, 2017 •
edited
Loading

  • Version: any with fixtures module
  • Platform: Windows
  • Subsystem: test

Refs: #16023 (see #16023 (comment))

cc @jasnell
@vsemozhetbyt vsemozhetbyt added test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Oct 6, 2017
bzoz added a commit to JaneaSystems/node that referenced this issue Oct 10, 2017
@bzoz
win, test: escape script filename on Windows
8f87a8a 
Escape backslashes in script filename on Windows in a CLI test.

Fixes: nodejs#16057
Fixes: nodejs#16023
@bzoz bzoz mentioned this issue Oct 10, 2017
Closed
2 tasks
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 15, 2017
@bzoz @addaleax
test: escape script filename on Windows
b854a72 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: nodejs/node#16124
Fixes: nodejs/node#16057 and #16023
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this issue Oct 18, 2017
@bzoz @targos
test: escape script filename on Windows
e3ac7b1 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 16, 2017
@bzoz @MylesBorins
test: escape script filename on Windows
5f7469a 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 21, 2017
@bzoz @MylesBorins
test: escape script filename on Windows
548b74c 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 28, 2017
@bzoz @MylesBorins
test: escape script filename on Windows
04f3f6d 
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

win, test: escape script filename on Windows JaneaSystems/node
1 participant
@vsemozhetbyt