-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-net-dns-custom-lookup failing on many machines #1527
Comments
(edited to say that it's failing on many machines, I just happened to be focusing on Ubuntu 15.04 as a new addition and assumed this was a new failure) |
On it. Can I get access to be able to kick off a build? |
hm I must be missing something. It looks like some of those machines are unable to resolve |
I think @jbergstroem was recently tackling this with the FreeBSD machines, related perhaps? |
Very well could be. The ones in particular I was looking at are the Ubuntu boxes. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=ubuntu1204-64/607/tapTestReport/test.tap-460/. Wonder if it's possible that they do not really support IPv6? |
also in /etc/hosts:
|
ahh that could be it. The test is trying to lookup |
yes, or you could use |
@rvagg what is that hosts file from? as it looks incorrect. This is from a 14.04 host for example, from what i understand
As long as the work around "falls back" that should be ok, but
|
I'm not sure if this is distro default, but yeah - I can confirm that hosts lack a |
That's slightly different. In FreeBSD jails we couldn't control routing of 127.0.0.1 which means there were no way of handling the situation other than passing an expected result -- in that case through an environment variable. In this case I'd suggest we do as mentioned above, edit hosts to add a ipv6 default for |
these build machines are pretty much unmolested with just the basics installed for what we need. See the kinds of defaults we're dealing with, quite mixed:
|
The assertion made an assumption that the IPv6 address would always be `::1`. Since the address can be different on different platforms, it has been changed to allow multiple addresses. Fixes: nodejs#1527 PR-URL: nodejs#1531 Reviewed-By: Rod Vagg <[email protected]>
Fixed via bfae823. Sorry for breaking the build |
One for @evanlucas I think, see https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/591/ - perhaps make it more flexible than just
::1
as some similar tests are.The text was updated successfully, but these errors were encountered: