Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document require('console').Console class #1359

Closed
JacksonTian opened this issue Apr 7, 2015 · 6 comments
Closed

Document require('console').Console class #1359

JacksonTian opened this issue Apr 7, 2015 · 6 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@JacksonTian
Copy link
Contributor

The default console object is an instance of Console, maybe we can document it for developers.
@mscdex mscdex added the doc Issues and PRs related to the documentations. label Apr 7, 2015
@bnoordhuis
Copy link
Member

I suppose that is fine but what exactly would you document?

@JacksonTian
Copy link
Contributor Author

I'd like to do it.

@bnoordhuis
Copy link
Member

Go for it, @JacksonTian. :-)

@benjamingr
Copy link
Member

I think in general you can just make a PR in the future instead of opening an issue for this sort of thing :)

@JacksonTian
Copy link
Contributor Author

The PR is here: #1388

silverwind pushed a commit that referenced this issue Apr 11, 2015
@JacksonTian @silverwind
doc: document Console class
2bc3532 
document Console class to tell user can use it.

PR-URL: #1388
Fixes: #1359
Reviewed-By: Roman Reiss <[email protected]>
@silverwind
Copy link
Contributor

Fixed in 2bc3532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mscdex @silverwind @bnoordhuis @JacksonTian @benjamingr