Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel/test-npm-install failure on ARM - Intermittent ? #13498

Closed
mhdawson opened this issue Jun 6, 2017 · 5 comments
Closed

parallel/test-npm-install failure on ARM - Intermittent ? #13498

mhdawson opened this issue Jun 6, 2017 · 5 comments
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jun 6, 2017

  • Version: master
  • Platform: ARM
  • Subsystem: npm

Possibly intermittent or a network issue. Opening to track.

https://ci.nodejs.org/job/node-test-binary-arm/8512/RUN_SUBSET=5,label=pi3-raspbian-jessie/console

not ok 124 parallel/test-npm-install
  ---
  duration_ms: 120.202
  severity: fail
  stack: |-
    timeout
  ...
@mscdex mscdex added arm Issues and PRs related to the ARM platform. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. labels Jun 6, 2017
@Trott
Copy link
Member

Trott commented Jul 3, 2017

The test was marked FLAKY by @refack: https://github.com/nodejs/node/pull/14035/commits/ed19a18
Problem still happening intermittently.

[refack] updated commit link

@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 3, 2017
@refack
Copy link
Contributor

refack commented Jul 4, 2017

https://ci.nodejs.org/job/node-test-binary-arm/9040/RUN_SUBSET=3,label=pi3-raspbian-jessie/

128		parallel/test-npm-install	TODO : Fix flaky test
		duration_ms	120.128
		severity	fail
		stack		timeout

@Trott
Copy link
Member

Trott commented Jul 14, 2017

Failing on Windows too:

https://ci.nodejs.org/job/node-test-binary-windows/9816/RUN_SUBSET=0,VS_VERSION=vcbt2015,label=win10/console

not ok 226 parallel/test-npm-install
  ---
  duration_ms: 0.901
  severity: fail
  stack: |-
    assert.js:48
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: npm install got error code 1
        at ChildProcess.handleExit (c:\workspace\node-test-binary-windows\RUN_SUBSET\0\VS_VERSION\vcbt2015\label\win10\test\parallel\test-npm-install.js:54:10)
        at ChildProcess.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\0\VS_VERSION\vcbt2015\label\win10\test\common\index.js:513:15)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:201:12)
  ...

@BridgeAR
Copy link
Member

Is this still an issue? I am not aware that we ran into this one recently. The test itself was changed to output better debugging information in case of a failure since this was reported.

@Trott
Copy link
Member

Trott commented Sep 29, 2017

Haven't noticed it lately although I haven't been as meticulous about watching CI as I once was. Nonetheless, I think this can be closed. It can always be re-opened if it starts failing again.

@Trott Trott closed this as completed Sep 29, 2017
Trott added a commit to Trott/io.js that referenced this issue Mar 8, 2018
I haven't seen test-npm-install fail on arm in a long time. There is no
open issue for it being unreliable. Remove flaky designation in
parallel.status file. (If it turns out it is flaky, it's easy enough to
open an issue and restore the flaky designation.)

Ref: nodejs#13498
Trott added a commit that referenced this issue Mar 10, 2018
I haven't seen test-npm-install fail on arm in a long time. There is no
open issue for it being unreliable. Remove flaky designation in
parallel.status file. (If it turns out it is flaky, it's easy enough to
open an issue and restore the flaky designation.)

Ref: #13498

PR-URL: #19216
Refs: #13498
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this issue Mar 17, 2018
I haven't seen test-npm-install fail on arm in a long time. There is no
open issue for it being unreliable. Remove flaky designation in
parallel.status file. (If it turns out it is flaky, it's easy enough to
open an issue and restore the flaky designation.)

Ref: #13498

PR-URL: #19216
Refs: #13498
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 20, 2018
I haven't seen test-npm-install fail on arm in a long time. There is no
open issue for it being unreliable. Remove flaky designation in
parallel.status file. (If it turns out it is flaky, it's easy enough to
open an issue and restore the flaky designation.)

Ref: #13498

PR-URL: #19216
Refs: #13498
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
I haven't seen test-npm-install fail on arm in a long time. There is no
open issue for it being unreliable. Remove flaky designation in
parallel.status file. (If it turns out it is flaky, it's easy enough to
open an issue and restore the flaky designation.)

Ref: nodejs#13498

PR-URL: nodejs#19216
Refs: nodejs#13498
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

5 participants