-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: res.getHeaders return value wrong in docs #12885
Comments
More concretely |
See #12883 (comment) – can please you be precise about what the issue is or what you want to do here? Otherwise this issue is just stating facts. |
If there is a reason why it has a |
Yes, because header names can clash with the built-in fields of Object.prototype (for example with
Are you talking about docs? |
Yes |
You can probably just copy the text from |
* also correct language for the same note for querystring.parse * add assertions for said note Fixes: nodejs#12885
* also correct language for the same note for querystring.parse * add assertions for said note PR-URL: nodejs#12887 Fixes: nodejs#12885 Refs: nodejs#12883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Fixed by: #12887 |
* also correct language for the same note for querystring.parse * add assertions for said note PR-URL: nodejs#12887 Fixes: nodejs#12885 Refs: nodejs#12883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Ref: https://github.com/nodejs/node/pull/12883/files#r115149721
Fails with
AssertionError [ERR_ASSERTION]: false == true
In contradiction to API https://nodejs.org/api/http.html#http_response_getheaders
The text was updated successfully, but these errors were encountered: