N-API documentation appears on 7.10.0 #12833
Comments
mscdex
added
node-api
|
/cc @nodejs/n-api |
|
Yes, this is weird, the file isn’t even there in the v7.10.0 tag. @nodejs/build ideas? |
|
To double check I checked out v7.x and build the docs. No n-api. |
|
Does not show for the 6.x docs, so seems specific to 7.x |
|
There seems to be 2 copies in the 7.10.0 and 7.x directories. The second which is one level down from the first (https://nodejs.org/dist/v7.10.0/docs/doc/api) does not have N-API. |
|
I've asked in the build IRC channel who knows how the docs are built for the website to see if they can point me in the right direction. |
|
looking in to it |
|
These other versions have both a docs/api and docs/doc/api: v4.0.0 Seems random, must be something to do with our build process (which is all in So far in my checking, only 7.10.0 seem to have different content and that difference is only the addition of the n-api docs. Very strange! Going deeper, will let you know when I find something, if you don't hear from me soon, send help! |
|
Yea, I had actually cherry-picked it by accident initially, but pulled it back out when I cut the release. Sorry if I caused this |
|
@evanlucas how close to the release? and did you force-push? it's possible that these double directories are from dirty directories being reused but I'm still scratching my head how the rest are identical but this one is different. |
|
Got it! you get the double directory if CI rebuilds the docs before its promoted, there's an So my assumption here is that 7.10.0 was first built with the n-api commit in it, then was rebuilt without it, so the docs that come from the release commit are in docs/doc/api/ and the docs that that are from the abandoned commit that was first built are in docs/api/. I'll come up with a fix for I'll also manually sort out that 7.10.0 directory issue by nuking docs/api/ and moving docs/doc/api/ up to docs/api/ - @nodejs/build can I get a +1 on doing that? |
Fixes: nodejs#12833 PR-URL:
|
#12957 is the fix |
|
@rvagg yay! Thanks for figuring this out. Apologies for causing the problem, although I guess it is good that we know about it now :] |
Fixes: #12833 PR-URL: #12957 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fixes: #12833 PR-URL: #12957 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fixes: #12833 PR-URL: #12957 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fixes: #12833 PR-URL: #12957 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fixes: #12833 PR-URL: #12957 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
https://nodejs.org/dist/latest-v7.x/docs/api/n-api.html
N-API was not supposed to land on v7.x, right?
The text was updated successfully, but these errors were encountered: