Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The inspector process.on(SIGPROF) warning is non-standard. #12706

Closed
Fishrock123 opened this issue Apr 27, 2017 · 6 comments
Closed

The inspector process.on(SIGPROF) warning is non-standard. #12706

Fishrock123 opened this issue Apr 27, 2017 · 6 comments
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory.

Comments

@Fishrock123
Copy link
Contributor

Fishrock123 commented Apr 27, 2017 •
edited
Loading

  • Version: master (as of yesterday?)
  • Platform: macOS
  • Subsystem: src

An internal project is generating this warning when run:

process.on(SIGPROF) is reserved while debugging

It was not immediately clear to me that this was indeed from node, since no (node:pid) prefix was attached.

The warning is emitted from here and was added in 84ad31f about a year ago (though I'm not sure inspector was on by default then). My understanding is that this warning does not happen for us on LTS versions of Node.

Edit: We are not launching the inspector in any way when running into this.
@Fishrock123 Fishrock123 added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 27, 2017
@Fishrock123
Copy link
Contributor Author

--trace-warnings also does not work to find where this warning is originating from, although I suspect it was from one of those "ensure this callback is run on any exit" modules.

@cjihrig
Copy link
Contributor

cjihrig commented Apr 27, 2017

I don't think it shows up as an official warning because it's just a print statement. I think it would have to use ProcessEmitWarning().

cjihrig added a commit to cjihrig/node that referenced this issue May 11, 2017
@cjihrig
src: make SIGPROF message a real warning
b6001a2 
This commit replaces a fprintf() with a call to
ProcessEmitWarning().

Refs: nodejs#12706
PR-URL: nodejs#12709
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
@cjihrig
src: make SIGPROF message a real warning
18cf5fe 
This commit replaces a fprintf() with a call to
ProcessEmitWarning().

Refs: nodejs#12706
PR-URL: nodejs#12709
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Jun 15, 2017 •
edited
Loading

Refs: #12709 (the above commit(s))

@pmuellr pmuellr mentioned this issue Jun 15, 2017
Closed
@Trott
Copy link
Member

Trott commented Apr 30, 2018

What should we do about this? Nothing? Change it to emit a warning? Something else?

@cjihrig
Copy link
Contributor

cjihrig commented May 5, 2018

This is a proper warning since #12709. The only question is whether or not the inspector should reserve SIGPROF, even when it's not in use. This check is always true if the inspector is started, which is different from active (HasConnectedSessions()).

@jasnell
Copy link
Member

jasnell commented Aug 11, 2018

Given that it's now a proper warning, I think we should close this issue. Whether inspector should reserve SIGPROF is a separate concern.

@jasnell jasnell closed this as completed Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasnell @Trott @Fishrock123 @cjihrig