Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simple/test-fs-symlink-dir-junction-relative broken on linux #126

Closed
bnoordhuis opened this issue Dec 9, 2014 · 3 comments
Closed
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@bnoordhuis
Copy link
Member

$ out/x64.release/node test/simple/test-fs-symlink-dir-junction-relative.js
linkData: /home/bnoordhuis/src/v0.12/test/fixtures/cycles
linkPath: /home/bnoordhuis/src/v0.12/test/tmp/cycles_link
relative target: ../fixtures/cycles

assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: "/home/bnoordhuis/src/fixtures/cycles" == "/home/bnoordhuis/src/v0.12/test/fixtures/cycles"
    at /home/bnoordhuis/src/v0.12/test/simple/test-fs-symlink-dir-junction-relative.js:54:14
    at Object.oncomplete (fs.js:95:15)

Reverting 7014b7c makes no difference. /cc @piscisaureus

@bnoordhuis bnoordhuis added confirmed-bug Issues with confirmed bugs. v0.12 labels Dec 9, 2014
@piscisaureus
Copy link
Contributor

@bnoordhuis I think the test is supposed to be ran from the "simple" directory

@bnoordhuis
Copy link
Member Author

It's also broken when run through the test runner:

$ python tools/test.py --arch=x64 --mode=release simple/test-fs-symlink-dir-junction-relative
=== release test-fs-symlink-dir-junction-relative ===                    
Path: simple/test-fs-symlink-dir-junction-relative
linkData: /home/bnoordhuis/src/v0.12/test/fixtures/cycles
linkPath: /home/bnoordhuis/src/v0.12/test/tmp/cycles_link
relative target: ../fixtures/cycles
assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: "/home/bnoordhuis/src/fixtures/cycles" == "/home/bnoordhuis/src/v0.12/test/fixtures/cycles"
    at /home/bnoordhuis/src/v0.12/test/simple/test-fs-symlink-dir-junction-relative.js:54:14
    at Object.oncomplete (fs.js:95:15)
Command: out/x64.release/node /home/bnoordhuis/src/v0.12/test/simple/test-fs-symlink-dir-junction-relative.js
[00:00|% 100|+   0|-   1]: Done                                         

piscisaureus added a commit to piscisaureus/node2 that referenced this issue Dec 9, 2014
  * The test no longer relies on being invoked from a particular
    working directory to function properly.
  * fs.symlink() and fs.symlinkSync() are both tested.
  * The test now cleans up after itself.

This commit fixes nodejs#126

R=@bnoordhuis
piscisaureus added a commit that referenced this issue Dec 9, 2014
  * The test no longer relies on being invoked from a particular
    working directory to function properly.
  * fs.symlink() and fs.symlinkSync() are both tested.
  * The test now cleans up after itself.

This commit fixes #126

PR-URL: #129
Reviewed-By: Ben Noordhuis <[email protected]>
@piscisaureus
Copy link
Contributor

Fixed in 4efc02a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

No branches or pull requests

2 participants