New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6.x crash with illegal spread as single arrow parameter #12017

Closed

targos opened this issue Mar 24, 2017 · 1 comment

Labels

confirmed-bug v8 engine

Member

targos commented Mar 24, 2017

Version: 6.10.1
Platform: Linux
Subsystem: V8

Repro: node -e "(...[42]) => 42"

Fix: v8/v8@b9f682b
I found this while investigating #11977

The text was updated successfully, but these errors were encountered:

targos added confirmed-bug v8 engine labels

targos added a commit to targos/node that referenced this issue


          deps: cherry-pick b9f682b from upstream V8

7a38c51

Original commit message:

    Fix bug with illegal spread as single arrow parameter

    [email protected]
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{nodejs#37196}

Fixes: nodejs#12017

MylesBorins pushed a commit that referenced this issue


          deps: cherry-pick b9f682b from upstream V8

ba105fd

Original commit message:

    Fix bug with illegal spread as single arrow parameter

    [email protected]
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

MylesBorins mentioned this issue

Regressions in v4.8.1 and v6.10.1 nodejs/Release#193

Closed

MylesBorins pushed a commit that referenced this issue


          deps: cherry-pick b9f682b from upstream V8

78e27f4

Original commit message:

    Fix bug with illegal spread as single arrow parameter

    [email protected]
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

MylesBorins pushed a commit that referenced this issue


          deps: cherry-pick b9f682b from upstream V8

8dfc710

Original commit message:

    Fix bug with illegal spread as single arrow parameter

    [email protected]
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

Member Author

targos commented Apr 7, 2017

Fixed in 8dfc710

targos closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment