-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failed test: parallel/test-fs-access.js #1031
Comments
@jbergstroem you should check out the same test in joyent/node. I think we are interested in the relevant parts of nodejs/node-v0.x-archive@4823afc and nodejs/node-v0.x-archive@28d0cbb. |
@cjihrig Yeah, I did something similar but the assumption that's made isn't entirely correct. On other platforms (I tested instance FreeBSD), running as root doesn't result in a test fail. I'd like to know more about which platforms fail and pass before assuming we skip. Edit: Actually, I suck. Didn't run my tests properly. I'll create a PR that skips the specific test if we're uid 0. |
Superusers can open files with W_OK permission even though their mode is set to 0444. Patch originally from nodejs/node-v0.x-archive@28d0cbbd. Fixes nodejs#1031. PR-Url: nodejs#1031
Superusers can open files with W_OK permission even though their mode is set to 0444. This commit makes the test attempt to change its uid to nobody on non-Windows platforms. Patch originally from nodejs/node-v0.x-archive@28d0cbbd. Fixes: #1031 PR-URL: #1037 Reviewed-By: Colin Ihrig <[email protected]>
Closed in fd3ea29 |
On a linux amd64 3.18.0 system running glibc 2.20, an error event isn't thrown when trying to open a readonly file with W_OK as root (obviously works as intended as a user):
Stat:ing the file looks as it should (was esp. interested in mode):
I'll first try to establish that it is in fact a newer glibc before doing anything else.
The text was updated successfully, but these errors were encountered: