src: fix abort on uv_loop_init() failure

Fixes: #34855 PR-URL: #34874 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Aug 25, 2020 · fff1e7f · fff1e7f
1 parent 7666d95
commit fff1e7f
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
@@ -457,9 +457,17 @@ Maybe<bool> SyncProcessRunner::TryInitializeAndRunLoop(Local<Value> options) {
     SetError(UV_ENOMEM);
     return Just(false);
   }
-  CHECK_EQ(uv_loop_init(uv_loop_), 0);
+
+  r = uv_loop_init(uv_loop_);
+  if (r < 0) {
+    delete uv_loop_;
+    uv_loop_ = nullptr;
+    SetError(r);
+    return Just(false);
+  }
 
   if (!ParseOptions(options).To(&r)) return Nothing<bool>();
+
   if (r < 0) {
     SetError(r);
     return Just(false);