lib: add FormData global when fetch is enabled

PR-URL: #41956 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Apr 20, 2022 · f79cf35 · f79cf35
1 parent ca83d4f
commit f79cf35
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 0 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -335,6 +335,7 @@ module.exports = {
     atob: 'readable',
     performance: 'readable',
     fetch: 'readable',
+    FormData: 'readable',
     Headers: 'readable',
     Request: 'readable',
     Response: 'readable',

diff --git a/doc/api/globals.md b/doc/api/globals.md
@@ -306,6 +306,17 @@ added: REPLACEME
 
 A browser-compatible implementation of the [`fetch()`][] function.
 
+## Class `FormData`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental. Enable this API with the [`--experimental-fetch`][]
+> CLI flag.
+
+A browser-compatible implementation of {FormData}.
+
 ## `global`
 
 <!-- YAML

diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -43,6 +43,10 @@ rules:
       message: "Use `const { Event } = require('internal/event_target');` instead of the global."
     - name: EventTarget
       message: "Use `const { EventTarget } = require('internal/event_target');` instead of the global."
+    - name: FormData
+      message: "Use `const { FormData } = require('internal/deps/undici/undici');` instead of the global."
+    - name: Headers
+      message: "Use `const { Headers } = require('internal/deps/undici/undici');` instead of the global."
       # Intl is not available in primordials because it can be
       # disabled with --without-intl build flag.
     - name: Intl

diff --git a/lib/internal/bootstrap/pre_execution.js b/lib/internal/bootstrap/pre_execution.js
@@ -157,6 +157,7 @@ function setupFetch() {
 
   const undici = require('internal/deps/undici/undici');
   defineOperation(globalThis, 'fetch', undici.fetch);
+  exposeInterface(globalThis, 'FormData', undici.FormData);
   exposeInterface(globalThis, 'Headers', undici.Headers);
   exposeInterface(globalThis, 'Request', undici.Request);
   exposeInterface(globalThis, 'Response', undici.Response);

diff --git a/test/common/index.js b/test/common/index.js
@@ -296,6 +296,7 @@ if (global.PerformanceMeasure) {
 if (global.fetch) {
   knownGlobals.push(
     global.fetch,
+    global.FormData,
     global.Request,
     global.Response,
     global.Headers,

diff --git a/test/parallel/test-fetch.mjs b/test/parallel/test-fetch.mjs
@@ -7,6 +7,7 @@ import events from 'events';
 import http from 'http';
 
 assert.strictEqual(typeof globalThis.fetch, 'function');
+assert.strictEqual(typeof globalThis.FormData, 'function');
 assert.strictEqual(typeof globalThis.Headers, 'function');
 assert.strictEqual(typeof globalThis.Request, 'function');
 assert.strictEqual(typeof globalThis.Response, 'function');

diff --git a/test/wpt/test-url.js b/test/wpt/test-url.js
@@ -21,6 +21,15 @@ runner.setScriptModifier((obj) => {
     // created via `document.createElement`. So we need to ignore them and just
     // test `URL`.
     obj.code = obj.code.replace(/\["url", "a", "area"\]/, '[ "url" ]');
+  } else if (typeof FormData === 'undefined' &&
+      obj.filename.includes('urlsearchparams-constructor.any.js')) {
+    // TODO(XadillaX): Remove this `else if` after `FormData` is supported.
+
+    // Ignore test named `URLSearchParams constructor, FormData.` because we do
+    // not have `FormData`.
+    obj.code = obj.code.replace(
+      /('URLSearchParams constructor, object\.'\);[\w\W]+)test\(function\(\) {[\w\W]*?}, 'URLSearchParams constructor, FormData\.'\);/,
+      '$1');
   }
 });
 runner.pretendGlobalThisAs('Window');

diff --git a/tools/doc/type-parser.mjs b/tools/doc/type-parser.mjs
@@ -266,6 +266,7 @@ const customTypesMap = {
   'TextDecoderStream':
     'webstreams.md#class-textdecoderstream',
 
+  'FormData': 'https://developer.mozilla.org/en-US/docs/Web/API/FormData',
   'Headers': 'https://developer.mozilla.org/en-US/docs/Web/API/Headers',
   'Response': 'https://developer.mozilla.org/en-US/docs/Web/API/Response',
   'Request': 'https://developer.mozilla.org/en-US/docs/Web/API/Request',