os: make EOL configurable and read only

PR-URL: #14622 Fixes: #14619 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Aug 21, 2017 · f6caeb9 · f6caeb9
1 parent 3a886ff
commit f6caeb9
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/lib/os.js b/lib/os.js
@@ -140,7 +140,6 @@ function networkInterfaces() {
 module.exports = exports = {
   arch,
   cpus,
-  EOL: isWindows ? '\r\n' : '\n',
   endianness,
   freemem: getFreeMem,
   homedir: getHomeDirectory,
@@ -162,8 +161,17 @@ module.exports = exports = {
   tmpDir: deprecate(tmpdir, tmpDirDeprecationMsg, 'DEP0022')
 };
 
-Object.defineProperty(module.exports, 'constants', {
-  configurable: false,
-  enumerable: true,
-  value: constants
+Object.defineProperties(module.exports, {
+  constants: {
+    configurable: false,
+    enumerable: true,
+    value: constants
+  },
+
+  EOL: {
+    configurable: true,
+    enumerable: true,
+    writable: false,
+    value: isWindows ? '\r\n' : '\n'
+  }
 });
diff --git a/test/parallel/test-os-eol.js b/test/parallel/test-os-eol.js
@@ -0,0 +1,27 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const os = require('os');
+
+const eol = common.isWindows ? '\r\n' : '\n';
+
+assert.strictEqual(os.EOL, eol);
+
+common.expectsError(function() {
+  os.EOL = 123;
+}, {
+  type: TypeError,
+  message: /^Cannot assign to read only property 'EOL' of object '#<Object>'$/
+});
+
+const foo = 'foo';
+Object.defineProperties(os, {
+  EOL: {
+    configurable: true,
+    enumerable: true,
+    writable: false,
+    value: foo
+  }
+});
+assert.strictEqual(os.EOL, foo);