test_runner: remove redundant check from coverage

The code coverage reporting logic already filters out URLs that don't start with 'file:', so there is no need to also filter out URLs that start with 'node:'. PR-URL: #48070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
nodejs · Jul 6, 2023 · edda045 · edda045
1 parent 71cc43e
commit edda045
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/internal/test_runner/coverage.js b/lib/internal/test_runner/coverage.js
@@ -377,10 +377,13 @@ function mergeCoverage(merged, coverage) {
     const newScript = coverage[i];
     const { url } = newScript;
 
-    // Filter out core modules and the node_modules/ directory from results.
-    if (StringPrototypeStartsWith(url, 'node:') ||
-        StringPrototypeIncludes(url, '/node_modules/') ||
-        // On Windows some generated coverages are invalid.
+    // The first part of this check filters out the node_modules/ directory
+    // from the results. This filter is applied first because most real world
+    // applications will be dominated by third party dependencies. The second
+    // part of the check filters out core modules, which start with 'node:' in
+    // coverage reports, as well as any invalid coverages which have been
+    // observed on Windows.
+    if (StringPrototypeIncludes(url, '/node_modules/') ||
         !StringPrototypeStartsWith(url, 'file:')) {
       continue;
     }