test: prevent flakey test on pi2

Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: #5302 PR-URL: #5537 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Alexis Campailla <[email protected]>
nodejs · Mar 8, 2016 · e6210d5 · e6210d5
1 parent 40b36ba
commit e6210d5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -10,7 +10,6 @@ prefix parallel
 test-tick-processor     : PASS,FLAKY
 
 [$system==linux]
-test-process-getactivehandles : PASS,FLAKY
 test-tick-processor           : PASS,FLAKY
 
 [$system==macos]

diff --git a/test/parallel/test-process-getactivehandles.js b/test/parallel/test-process-getactivehandles.js
@@ -10,13 +10,16 @@ var clients_counter = 0;
 
 const server = net.createServer(function listener(c) {
   connections.push(c);
-}).listen(common.PORT, function makeConnections() {
-  for (var i = 0; i < NUM; i++) {
-    net.connect(common.PORT, function connected() {
-      clientConnected(this);
-    });
-  }
-});
+}).listen(common.PORT, makeConnection);
+
+
+function makeConnection() {
+  if (clients_counter >= NUM) return;
+  net.connect(common.PORT, function connected() {
+    clientConnected(this);
+    makeConnection();
+  });
+}
 
 
 function clientConnected(client) {