Skip to content

Commit

Permalink
build: add v8 requirement to test-v8* in Makefile
Browse files Browse the repository at this point in the history
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
targos authored and Myles Borins committed Jul 12, 2016
1 parent f711650 commit dfba60e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -227,22 +227,22 @@ test-timers:
test-timers-clean:
$(MAKE) --directory=tools clean

test-v8:
test-v8: v8
# note: performs full test unless QUICKCHECK is specified
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
--no-presubmit \
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
$(TAP_V8)

test-v8-intl:
test-v8-intl: v8
# note: performs full test unless QUICKCHECK is specified
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
$(TAP_V8_INTL)

test-v8-benchmarks:
test-v8-benchmarks: v8
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
--download-data $(QUICKCHECK_ARG) --no-presubmit \
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \
Expand Down

0 comments on commit dfba60e

Please sign in to comment.