src: add "missing" bash completion options

Currently, when using the bash completions for node the normal completions for filenames directories do not work. For example, after finding a node completion and then wanting to use tab completion for a filename in the test directory, it is only possible to get the name of the test directory completed, followed by a space. What is expected is to be able to continue with tab completion for directories. This commit adds options to the complete command to enable default bash completions. PR-URL: #33744 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Jun 30, 2020 · de48495 · de48495
1 parent b1f6584
commit de48495
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -829,7 +829,8 @@ std::string GetBashCompletion() {
          "    return 0\n"
          "  fi\n"
          "}\n"
-         "complete -F _node_complete node node_g";
+         "complete -o filenames -o nospace -o bashdefault "
+         "-F _node_complete node node_g";
   return out.str();
 }
 

diff --git a/test/parallel/test-bash-completion.js b/test/parallel/test-bash-completion.js
@@ -24,7 +24,8 @@ const suffix = `' -- "\${cur_word}") )
     return 0
   fi
 }
-complete -F _node_complete node node_g`.replace(/\r/g, '');
+complete -o filenames -o nospace -o bashdefault -F _node_complete node node_g`
+  .replace(/\r/g, '');
 
 assert.ok(
   output.includes(prefix),