fs: make fs.promises non-enumerable

This prevents the experimental feature warning from being emitted in cases where fs.promises is not actually used. PR-URL: #20632 Fixes: #20504 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
nodejs · May 12, 2018 · de06115 · de06115
1 parent e06c587
commit de06115
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -77,7 +77,7 @@ let warn = true;
 
 Object.defineProperty(fs, 'promises', {
   configurable: true,
-  enumerable: true,
+  enumerable: false,
   get() {
     if (warn) {
       warn = false;

diff --git a/test/parallel/test-fs-promises.js b/test/parallel/test-fs-promises.js
@@ -5,7 +5,8 @@ const assert = require('assert');
 const tmpdir = require('../common/tmpdir');
 const fixtures = require('../common/fixtures');
 const path = require('path');
-const fsPromises = require('fs').promises;
+const fs = require('fs');
+const fsPromises = fs.promises;
 const {
   access,
   chmod,
@@ -38,6 +39,10 @@ const tmpDir = tmpdir.path;
 
 common.crashOnUnhandledRejection();
 
+// fs.promises should not be enumerable as long as it causes a warning to be
+// emitted.
+assert.strictEqual(Object.keys(fs).includes('promises'), false);
+
 {
   access(__filename, 'r')
     .then(common.mustCall())