benchmark: terminate child process on Windows

test-benchmark-child-process failures reveal that child-process-exec-stdout benchmark sometimes leaves around a stray yes.exe process. Add code to terminate the process. PR-URL: #12658 Ref: #12560 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · May 1, 2017 · dbe9882 · dbe9882
1 parent 1359030
commit dbe9882
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/benchmark/child_process/child-process-exec-stdout.js b/benchmark/child_process/child-process-exec-stdout.js
@@ -10,7 +10,8 @@ const bench = common.createBenchmark(main, {
   dur: [5]
 });
 
-const exec = require('child_process').exec;
+const child_process = require('child_process');
+const exec = child_process.exec;
 function main(conf) {
   bench.start();
 
@@ -28,7 +29,12 @@ function main(conf) {
   });
 
   setTimeout(function() {
-    child.kill();
     bench.end(bytes);
+    if (process.platform === 'win32') {
+      // Sometimes there's a yes.exe process left hanging around on Windows...
+      child_process.execSync(`taskkill /f /t /pid ${child.pid}`);
+    } else {
+      child.kill();
+    }
   }, dur * 1000);
 }
diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status
@@ -7,7 +7,6 @@ prefix sequential
 [true] # This section applies to all platforms
 
 [$system==win32]
-test-benchmark-child-process  : PASS,FLAKY
 
 [$system==linux]