stream: accept iterable as a valid first argument

Fixes: #36437 PR-URL: #36479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Dec 21, 2020 · d8b5b94 · d8b5b94
1 parent 728f512
commit d8b5b94
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/internal/streams/pipeline.js b/lib/internal/streams/pipeline.js
@@ -144,7 +144,10 @@ async function pump(iterable, writable, finish) {
 function pipeline(...streams) {
   const callback = once(popCallback(streams));
 
-  if (ArrayIsArray(streams[0])) streams = streams[0];
+  // stream.pipeline(streams, callback)
+  if (ArrayIsArray(streams[0]) && streams.length === 1) {
+    streams = streams[0];
+  }
 
   if (streams.length < 2) {
     throw new ERR_MISSING_ARGS('streams');

diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js
@@ -1285,3 +1285,19 @@ const net = require('net');
   });
   const pipelined = addAbortSignal(ac.signal, pipeline([r, w], cb));
 }
+
+{
+  pipeline([1, 2, 3], PassThrough({ objectMode: true }),
+           common.mustSucceed(() => {}));
+
+  let res = '';
+  const w = new Writable({
+    write(chunk, encoding, callback) {
+      res += chunk;
+      callback();
+    },
+  });
+  pipeline(['1', '2', '3'], w, common.mustSucceed(() => {
+    assert.strictEqual(res, '123');
+  }));
+}