tls: remove sharedCreds in Server constructor

This commit removes the var sharedCreds which is just reassigned to this._sharedCreds in the following line. PR-URL: #20491 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · May 8, 2018 · d866984 · d866984
1 parent 31dfb0a
commit d866984
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -871,7 +871,7 @@ function Server(options, listener) {
   // Handle option defaults:
   this.setOptions(options);
 
-  var sharedCreds = tls.createSecureContext({
+  this._sharedCreds = tls.createSecureContext({
     pfx: this.pfx,
     key: this.key,
     passphrase: this.passphrase,
@@ -887,7 +887,6 @@ function Server(options, listener) {
     crl: this.crl,
     sessionIdContext: this.sessionIdContext
   });
-  this._sharedCreds = sharedCreds;
 
   this[kHandshakeTimeout] = options.handshakeTimeout || (120 * 1000);
   this[kSNICallback] = options.SNICallback;
@@ -898,11 +897,11 @@ function Server(options, listener) {
   }
 
   if (this.sessionTimeout) {
-    sharedCreds.context.setSessionTimeout(this.sessionTimeout);
+    this._sharedCreds.context.setSessionTimeout(this.sessionTimeout);
   }
 
   if (this.ticketKeys) {
-    sharedCreds.context.setTicketKeys(this.ticketKeys);
+    this._sharedCreds.context.setTicketKeys(this.ticketKeys);
   }
 
   // constructor call