build: fix GN build for cares/uv deps

PR-URL: #55477 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Nov 27, 2024 · d6746ac · d6746ac
1 parent 307a93c
commit d6746ac
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/deps/cares/unofficial.gni b/deps/cares/unofficial.gni
@@ -38,7 +38,10 @@ template("cares_gn_build") {
       ]
     }
 
-    include_dirs = [ "src/lib" ]
+    include_dirs = [
+      "src/lib",
+      "src/lib/include",
+    ]
     if (is_win) {
       include_dirs += [ "config/win32" ]
     } else if (is_linux) {
@@ -55,9 +58,6 @@ template("cares_gn_build") {
     }
 
     sources = gypi_values.cares_sources_common
-    if (is_win) {
-      sources += gypi_values.cares_sources_win
-    }
     if (is_linux) {
       sources += [ "config/linux/ares_config.h" ]
     }

diff --git a/deps/uv/unofficial.gni b/deps/uv/unofficial.gni
@@ -40,6 +40,7 @@ template("uv_gn_build") {
         "-Wno-extra-semi",
         "-Wno-implicit-fallthrough",
         "-Wno-missing-braces",
+        "-Wno-sign-compare",
         "-Wno-string-conversion",
         "-Wno-shadow",
         "-Wno-unreachable-code",

diff --git a/unofficial.gni b/unofficial.gni
@@ -68,6 +68,7 @@ template("node_gn_build") {
       "-Wno-extra-semi",
       "-Wno-implicit-fallthrough",
       "-Wno-macro-redefined",
+      "-Wno-missing-braces",
       "-Wno-return-type",
       "-Wno-shadow",
       "-Wno-sometimes-uninitialized",