benchmark: make temp file path configurable

In three fs benchmarks, a temp file is created in the source tree. For tests, allow the location to be configurable so it gets written to the test temp directory instead. Additionally, shave about a second off the test running time by setting `dur` to `0.1` instead of `1`. PR-URL: #17811 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
nodejs · Dec 24, 2017 · d610fad · d610fad
1 parent 4444b6b
commit d610fad
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/benchmark/fs/read-stream-throughput.js b/benchmark/fs/read-stream-throughput.js
@@ -3,7 +3,7 @@
 
 const path = require('path');
 const common = require('../common.js');
-const filename = path.resolve(__dirname,
+const filename = path.resolve(process.env.NODE_TMPDIR || __dirname,
                               `.removeme-benchmark-garbage-${process.pid}`);
 const fs = require('fs');
 const assert = require('assert');

diff --git a/benchmark/fs/readfile.js b/benchmark/fs/readfile.js
@@ -5,7 +5,7 @@
 
 const path = require('path');
 const common = require('../common.js');
-const filename = path.resolve(__dirname,
+const filename = path.resolve(process.env.NODE_TMPDIR || __dirname,
                               `.removeme-benchmark-garbage-${process.pid}`);
 const fs = require('fs');
 

diff --git a/benchmark/fs/write-stream-throughput.js b/benchmark/fs/write-stream-throughput.js
@@ -3,7 +3,7 @@
 
 const path = require('path');
 const common = require('../common.js');
-const filename = path.resolve(__dirname,
+const filename = path.resolve(process.env.NODE_TMPDIR || __dirname,
                               `.removeme-benchmark-garbage-${process.pid}`);
 const fs = require('fs');
 

diff --git a/test/parallel/test-benchmark-fs.js b/test/parallel/test-benchmark-fs.js
@@ -1,17 +1,17 @@
 'use strict';
 
-require('../common');
+const common = require('../common');
 const runBenchmark = require('../common/benchmark');
 
 runBenchmark('fs', [
   'n=1',
   'size=1',
-  'dur=1',
+  'dur=0.1',
   'len=1024',
   'concurrent=1',
   'pathType=relative',
   'statType=fstat',
   'statSyncType=fstatSync',
   'encodingType=buf',
   'filesize=1024'
-]);
+], { NODE_TMPDIR: common.tmpDir });