Skip to content

Commit

Permalink
async_hooks: improve AsyncResource performance
Browse files Browse the repository at this point in the history
Accessing symbols is generally quite expensive and so is emitInit,
only do both when actually required.

PR-URL: #27032
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
apapirovski authored and danbev committed Apr 5, 2019
1 parent af03de4 commit d3d4e10
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
25 changes: 14 additions & 11 deletions lib/async_hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const {
emitBefore,
emitAfter,
emitDestroy,
initHooksExist,
} = internal_async_hooks;

// Get symbols
Expand Down Expand Up @@ -146,29 +147,31 @@ class AsyncResource {
throw new ERR_INVALID_ASYNC_ID('triggerAsyncId', triggerAsyncId);
}

this[async_id_symbol] = newAsyncId();
const asyncId = newAsyncId();
this[async_id_symbol] = asyncId;
this[trigger_async_id_symbol] = triggerAsyncId;

// This prop name (destroyed) has to be synchronized with C++
this[destroyedSymbol] = { destroyed: false };
const destroyed = { destroyed: false };
this[destroyedSymbol] = destroyed;

emitInit(
this[async_id_symbol], type, this[trigger_async_id_symbol], this
);
if (initHooksExist()) {
emitInit(asyncId, type, triggerAsyncId, this);
}

if (!opts.requireManualDestroy) {
registerDestroyHook(this, this[async_id_symbol], this[destroyedSymbol]);
registerDestroyHook(this, asyncId, destroyed);
}
}

runInAsyncScope(fn, thisArg, ...args) {
emitBefore(this[async_id_symbol], this[trigger_async_id_symbol]);
let ret;
const asyncId = this[async_id_symbol];
emitBefore(asyncId, this[trigger_async_id_symbol]);
try {
ret = Reflect.apply(fn, thisArg, args);
return Reflect.apply(fn, thisArg, args);
} finally {
emitAfter(this[async_id_symbol]);
emitAfter(asyncId);
}
return ret;
}

emitDestroy() {
Expand Down
5 changes: 1 addition & 4 deletions lib/internal/async_hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,14 +286,11 @@ function defaultTriggerAsyncIdScope(triggerAsyncId, block, ...args) {
const oldDefaultTriggerAsyncId = async_id_fields[kDefaultTriggerAsyncId];
async_id_fields[kDefaultTriggerAsyncId] = triggerAsyncId;

let ret;
try {
ret = Reflect.apply(block, null, args);
return Reflect.apply(block, null, args);
} finally {
async_id_fields[kDefaultTriggerAsyncId] = oldDefaultTriggerAsyncId;
}

return ret;
}


Expand Down

0 comments on commit d3d4e10

Please sign in to comment.