src: handle empty Maybe in uv binding initialize

This can fail when terminating a Worker that loads the `uv` binding at the same time. Refs: #25061 (comment) Fixes: #25134 PR-URL: #25079 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Dec 25, 2018 · c6388ed · c6388ed
1 parent d1a98a8
commit c6388ed
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/uv.cc b/src/uv.cc
@@ -81,9 +81,11 @@ void Initialize(Local<Object> target,
     OneByteString(isolate, #name),                                            \
     OneByteString(isolate, msg)                                               \
   };                                                                          \
-  err_map->Set(context,                                                       \
-               Integer::New(isolate, UV_##name),                              \
-               Array::New(isolate, arr, arraysize(arr))).ToLocalChecked();    \
+  if (err_map->Set(context,                                                   \
+                   Integer::New(isolate, UV_##name),                          \
+                   Array::New(isolate, arr, arraysize(arr))).IsEmpty()) {     \
+    return;                                                                   \
+  }                                                                           \
 } while (0);
   UV_ERRNO_MAP(V)
 #undef V