fs: make mutating options in Callback readdir() not affect results

PR-URL: #56057 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 13, 2024 · c21a9e0 · c21a9e0
1 parent 2df8257
commit c21a9e0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -1530,6 +1530,9 @@ function readdir(path, options, callback) {
   }
 
   if (options.recursive) {
+    // Make shallow copy to prevent mutating options from affecting results
+    options = copyObject(options);
+
     readdirRecursive(path, options, callback);
     return;
   }

diff --git a/test/parallel/test-fs-readdir-types.js b/test/parallel/test-fs-readdir-types.js
@@ -86,6 +86,14 @@ fs.readdir(readdirDir, {
   assertDirents(await direntsPromise);
 })().then(common.mustCall());
 
+{
+  const options = { recursive: true, withFileTypes: true };
+  fs.readdir(readdirDir, options, common.mustSucceed((dirents) => {
+    assertDirents(dirents);
+  }));
+  options.withFileTypes = false;
+}
+
 // Check for correct types when the binding returns unknowns
 const UNKNOWN = constants.UV_DIRENT_UNKNOWN;
 const oldReaddir = binding.readdir;