tools: refactor js2c.py for maximal Python3 compatibility

* add explicit `--target` argument to enable succinct gyp declaration * simplify js2c semantics PR-URL: #25518 Reviewed-By: Christian Clauss <[email protected]>
nodejs · May 18, 2019 · bfbc035 · bfbc035
1 parent a49ab0f
commit bfbc035
Show file tree

Hide file tree

Showing 2 changed files with 171 additions and 130 deletions.
diff --git a/node.gyp b/node.gyp
@@ -859,6 +859,8 @@
           'action_name': 'node_js2c',
           'process_outputs_as_sources': 1,
           'inputs': [
+            # Put the code first so it's a dependency and can be used for invocation.
+            'tools/js2c.py',
             '<@(library_files)',
             'config.gypi',
             'tools/js2c_macros/check_macros.py'
@@ -878,9 +880,8 @@
             }]
           ],
           'action': [
-            'python', 'tools/js2c.py',
-            '<@(_outputs)',
-            '<@(_inputs)',
+            'python', '<@(_inputs)',
+            '--target', '<@(_outputs)',
           ],
         },
       ],