inspector: check if connected before waiting

Fixes: #10093 PR-URL: #10094 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Dec 13, 2016 · b41db33 · b41db33
1 parent 19d7197
commit b41db33
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -548,10 +548,12 @@ bool AgentImpl::IsStarted() {
 }
 
 void AgentImpl::WaitForDisconnect() {
-  shutting_down_ = true;
-  fprintf(stderr, "Waiting for the debugger to disconnect...\n");
-  fflush(stderr);
-  inspector_->runMessageLoopOnPause(0);
+  if (state_ == State::kConnected) {
+    shutting_down_ = true;
+    fprintf(stderr, "Waiting for the debugger to disconnect...\n");
+    fflush(stderr);
+    inspector_->runMessageLoopOnPause(0);
+  }
 }
 
 #define READONLY_PROPERTY(obj, str, var)                                      \

diff --git a/test/inspector/test-inspector-stops-no-file.js b/test/inspector/test-inspector-stops-no-file.js
@@ -0,0 +1,15 @@
+'use strict';
+require('../common');
+const spawn = require('child_process').spawn;
+
+const child = spawn(process.execPath,
+                    [ '--inspect', 'no-such-script.js' ],
+                    { 'stdio': 'inherit' });
+
+function signalHandler(value) {
+  child.kill();
+  process.exit(1);
+}
+
+process.on('SIGINT', signalHandler);
+process.on('SIGTERM', signalHandler);