Skip to content

Commit

Permalink
build: don't print directory for GNUMake
Browse files Browse the repository at this point in the history
Currently when running make targets the directory is printed on some
operating systems (Linux for example):

$ make lint
make[1]: Entering directory '/work/node'
Running JS linter...
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules
--ext=.js,.md \
  benchmark doc lib test tools
make[1]: Leaving directory '/work/node'
make[1]: Entering directory '/work/node'
Running C++ linter...

On other operating systems the directory is not printed. This commit
suggests adding a flag to make this consistent for GNUMake by not
printing the directory.

PR-URL: #13042
Reviewed-By: Gibson Fahnestock <[email protected]>
  • Loading branch information
danbev committed May 17, 2017
1 parent f2ba06d commit ad7b98b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ LOGLEVEL ?= silent
OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
COVTESTS ?= test
GTEST_FILTER ?= "*"
GNUMAKEFLAGS += --no-print-directory

ifdef JOBS
PARALLEL_ARGS = -j $(JOBS)
Expand Down

0 comments on commit ad7b98b

Please sign in to comment.