lib: update Symbol.toStringTag by SymbolToStringTag primordial

PR-URL: #30908 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Dec 13, 2019 · ac1cc5c · ac1cc5c
1 parent fb8b483
commit ac1cc5c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -8,6 +8,7 @@ const {
   ObjectDefineProperties,
   ObjectGetOwnPropertyDescriptors,
   Symbol,
+  SymbolToStringTag,
 } = primordials;
 
 const {
@@ -358,7 +359,7 @@ ObjectDefineProperties(
     'encode': { enumerable: true },
     'encodeInto': { enumerable: true },
     'encoding': { enumerable: true },
-    [Symbol.toStringTag]: {
+    [SymbolToStringTag]: {
       configurable: true,
       value: 'TextEncoder'
     } });
@@ -554,7 +555,7 @@ function makeTextDecoderJS() {
   ObjectDefineProperties(TextDecoder.prototype, {
     decode: { enumerable: true },
     [inspect]: { enumerable: false },
-    [Symbol.toStringTag]: {
+    [SymbolToStringTag]: {
       configurable: true,
       value: 'TextDecoder'
     }

diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -13,6 +13,7 @@ const {
   ReflectOwnKeys,
   Symbol,
   SymbolIterator,
+  SymbolToStringTag,
 } = primordials;
 
 const { inspect } = require('internal/util/inspect');
@@ -431,7 +432,7 @@ ObjectDefineProperties(URL.prototype, {
       return ret;
     }
   },
-  [Symbol.toStringTag]: {
+  [SymbolToStringTag]: {
     configurable: true,
     value: 'URL'
   },
@@ -859,7 +860,7 @@ function serializeParams(array) {
 // Mainly to mitigate func-name-matching ESLint rule
 function defineIDLClass(proto, classStr, obj) {
   // https://heycam.github.io/webidl/#dfn-class-string
-  ObjectDefineProperty(proto, Symbol.toStringTag, {
+  ObjectDefineProperty(proto, SymbolToStringTag, {
     writable: false,
     enumerable: false,
     configurable: true,
@@ -1244,7 +1245,7 @@ defineIDLClass(URLSearchParamsIteratorPrototype, 'URLSearchParams Iterator', {
     } else {
       outputStr = ` ${outputStrs.join(', ')}`;
     }
-    return `${this[Symbol.toStringTag]} {${outputStr} }`;
+    return `${this[SymbolToStringTag]} {${outputStr} }`;
   }
 });
 

diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -15,8 +15,8 @@ const {
   ObjectPrototypePropertyIsEnumerable,
   ObjectPrototypeToString,
   StringPrototypeValueOf,
-  Symbol,
   SymbolPrototypeValueOf,
+  SymbolToStringTag,
 } = primordials;
 
 const { compare } = internalBinding('buffer');
@@ -120,7 +120,7 @@ function isEqualBoxedPrimitive(val1, val2) {
 
 function isIdenticalTypedArrayType(a, b) {
   // Fast path to reduce type checks in the common case.
-  const check = types[`is${a[Symbol.toStringTag]}`];
+  const check = types[`is${a[SymbolToStringTag]}`];
   if (check !== undefined && check(a)) {
     return check(b);
   }