buffer: switch to using InvalidCharacterError on encoding error

* Chrome and Firefox both use `InvalidCharacterError` when the string to be decoded is not correctly encoded * Remove unnecessary atob test
nodejs · Apr 9, 2022 · a85b856 · a85b856
1 parent 08e4c75
commit a85b856
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -1282,7 +1282,7 @@ function atob(input) {
   if (nonAsciiWhitespaceCharCount % 4 === 1) {
     throw lazyDOMException(
       'The string to be decoded is not correctly encoded.',
-      'ValidationError');
+      'InvalidCharacterError');
   }
 
   return Buffer.from(input, 'base64').toString('latin1');

diff --git a/test/parallel/test-btoa-atob.js b/test/parallel/test-btoa-atob.js
@@ -25,7 +25,6 @@ strictEqual(atob([]), '');
 strictEqual(atob({ toString: () => '' }), '');
 strictEqual(atob({ [Symbol.toPrimitive]: () => '' }), '');
 
-throws(() => atob(), /ERR_MISSING_ARGS/);
 throws(() => atob(Symbol()), /TypeError/);
 [undefined, false, () => {}, 0, 1, 0n, 1n, -Infinity, [1], {}].forEach((value) =>
   throws(() => atob(value), { constructor: DOMException }));