Skip to content

Commit

Permalink
src: add context for TODO comment in env.cc
Browse files Browse the repository at this point in the history
Add more context around the TODO change required for achieving the
task. When destructuring the isolate and environment_vars from the
environment object, it is leading to recursive dependency and thus not
able to refactor it in a better way.

PR-URL: #37140
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
yashLadha authored and danielleadams committed Feb 16, 2021
1 parent 354df9e commit a6053dc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/env.cc
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,8 @@ Environment::Environment(IsolateData* isolate_data,

set_env_vars(per_process::system_environment);
// TODO(joyeecheung): pass Isolate* and env_vars to it instead of the entire
// env
// env, when the recursive dependency inclusion in "debug-utils.h" is
// resolved.
enabled_debug_list_.Parse(this);

// We create new copies of the per-Environment option sets, so that it is
Expand Down

0 comments on commit a6053dc

Please sign in to comment.