events: support useCapture boolean

PR-URL: #33618 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jun 18, 2020 · a3ef2b7 · a3ef2b7
1 parent 2e6ecea
commit a3ef2b7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -413,6 +413,9 @@ function validateListener(listener) {
 }
 
 function validateEventListenerOptions(options) {
+  if (typeof options === 'boolean') {
+    options = { capture: options };
+  }
   if (options == null || typeof options !== 'object')
     throw new ERR_INVALID_ARG_TYPE('options', 'object', options);
   const {

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -152,7 +152,14 @@ ok(EventTarget);
   eventTarget.addEventListener('foo', (event) => event.preventDefault());
   ok(!eventTarget.dispatchEvent(event));
 }
-
+{
+  // Adding event listeners with a boolean useCapture
+  const eventTarget = new EventTarget();
+  const event = new Event('foo');
+  const fn = common.mustCall((event) => strictEqual(event.type, 'foo'));
+  eventTarget.addEventListener('foo', fn, false);
+  eventTarget.dispatchEvent(event);
+}
 {
   const eventTarget = new NodeEventTarget();
   strictEqual(eventTarget.listenerCount('foo'), 0);