benchmark: fix chunky client benchmark execution

This commit fixes a few things for this benchmark: 1. Ensures the temporary directory for the unix socket exists. 2. Prevents the client code from being run directly because the server script is the one that calls out the client code. 3. Ensures the server is closed once the client benchmarks have finished. 4. Since this is an http benchmark, it should be moved to the http benchmarks subdirectory. PR-URL: #1257 Reviewed-By: Roman Reiss <[email protected]>
nodejs · Apr 3, 2015 · a081c7c · a081c7c
1 parent f1e5a13
commit a081c7c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/benchmark/net/chunky_http_client.js → benchmark/http/_chunky_http_client.js b/benchmark/net/chunky_http_client.js → benchmark/http/_chunky_http_client.js
diff --git a/...mark/net/http_server_for_chunky_client.js → ...ark/http/http_server_for_chunky_client.js b/...mark/net/http_server_for_chunky_client.js → ...ark/http/http_server_for_chunky_client.js
@@ -6,9 +6,15 @@ var fs = require('fs');
 var spawn = require('child_process').spawn;
 var common = require('../common.js')
 var test = require('../../test/common.js')
-var pep = path.dirname(process.argv[1]) + '/chunky_http_client.js';
+var pep = path.dirname(process.argv[1]) + '/_chunky_http_client.js';
 var PIPE = test.PIPE;
 
+try {
+  fs.accessSync(test.tmpDir, fs.F_OK);
+} catch (e) {
+  fs.mkdirSync(test.tmpDir);
+}
+
 var server;
 try {
   fs.unlinkSync(PIPE);
@@ -36,9 +42,10 @@ try {
   });
 
   child.stdout.pipe(process.stdout);
+  child.stderr.pipe(process.stderr);
 
-  child.on('exit', function (exitCode) {
-    console.error('Child exited with code: ' + exitCode);
+  child.on('close', function (exitCode) {
+    server.close();
   });
 
 } catch(e) {