Skip to content

Commit

Permalink
squash: add test that overwrites config variable
Browse files Browse the repository at this point in the history
  • Loading branch information
danbev committed Oct 24, 2017
1 parent 1707000 commit 9395fca
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/fixtures/overwrite-config-preload-module.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict'
const common = require('../common');
common.skipIfInspectorDisabled();

process.config = {};
41 changes: 41 additions & 0 deletions test/sequential/test-inspector-overwrite-config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Flags: --require ./test/fixtures/overwrite-config-preload-module.js
'use strict';

// This test ensures that overwriting a process configuration
// value does not affect code in bootstrap_node.js. Specifically this tests
// that the inspector console functions are bound even though
// overwrite-config-preload-module.js overwrote the process.config variable.

// We cannot do a check for the inspector because the configuration variables
// were reset/removed by overwrite-config-preload-module.js.
/* eslint-disable inspector-check */

const common = require('../common');
const assert = require('assert');
const inspector = require('inspector');
const msg = 'Test inspector logging';
let asserted = false;

async function testConsoleLog() {
const session = new inspector.Session();
session.connect();
session.on('inspectorNotification', (data) => {
if (data.method === 'Runtime.consoleAPICalled') {
assert.strictEqual(data.params.args.length, 1);
assert.strictEqual(data.params.args[0].value, msg);
asserted = true;
}
});
session.post('Runtime.enable');
console.log(msg);
session.disconnect();
}

common.crashOnUnhandledRejection();

async function runTests() {
await testConsoleLog();
assert.ok(asserted, 'log statement did not reach the inspector');
}

runTests();

0 comments on commit 9395fca

Please sign in to comment.