src: prefer param function check over args length

PR-URL: #23835 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
nodejs · Dec 3, 2018 · 9106ccf · 9106ccf
1 parent 5ed5f03
commit 9106ccf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -408,7 +408,7 @@ function open(path, flags, mode, callback) {
   path = toPathIfFileURL(path);
   validatePath(path);
   const flagsNumber = stringToFlags(flags);
-  if (arguments.length < 4) {
+  if (typeof mode === 'function') {
     callback = makeCallback(mode);
     mode = 0o666;
   } else {
@@ -788,7 +788,7 @@ function readdirSync(path, options) {
 }
 
 function fstat(fd, options, callback) {
-  if (arguments.length < 3) {
+  if (typeof options === 'function') {
     callback = options;
     options = {};
   }
@@ -799,7 +799,7 @@ function fstat(fd, options, callback) {
 }
 
 function lstat(path, options, callback) {
-  if (arguments.length < 3) {
+  if (typeof options === 'function') {
     callback = options;
     options = {};
   }
@@ -812,7 +812,7 @@ function lstat(path, options, callback) {
 }
 
 function stat(path, options, callback) {
-  if (arguments.length < 3) {
+  if (typeof options === 'function') {
     callback = options;
     options = {};
   }