Skip to content

Commit

Permalink
test: fix parameters in test-repl.js
Browse files Browse the repository at this point in the history
fixed order of parameters in assert.strictEqual() assertion functions,
first argument provided was the expected value and the second value
was the actual value.

this is backwards from the documentation for assertions like
assert.strictEqual() where the first value being tested and the second
value is the expected value

PR-URL: #23609
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
  • Loading branch information
binaryme authored and rvagg committed Nov 28, 2018
1 parent 454d0f1 commit 7872f23
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/parallel/test-repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,8 @@ function startTCPRepl() {
client.setEncoding('utf8');

client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);

resolveSocket(client);
}));
Expand Down Expand Up @@ -827,8 +827,8 @@ function startUnixRepl() {
client.setEncoding('utf8');

client.on('connect', common.mustCall(() => {
assert.strictEqual(true, client.readable);
assert.strictEqual(true, client.writable);
assert.strictEqual(client.readable, true);
assert.strictEqual(client.writable, true);

resolveSocket(client);
}));
Expand Down

0 comments on commit 7872f23

Please sign in to comment.