tools,bootstrap: preprocess gypi files to json

PR-URL: #19140 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
nodejs · Mar 9, 2018 · 7314b17 · 7314b17 · bnoordhuis · Mar 29, 2018
1 parent 099e621
commit 7314b17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/lib/internal/process.js b/lib/internal/process.js
@@ -128,16 +128,9 @@ function setupMemoryUsage() {
 function setupConfig(_source) {
   // NativeModule._source
   // used for `process.config`, but not a real module
-  var config = _source.config;
+  const config = _source.config;
   delete _source.config;
 
-  // strip the gyp comment line at the beginning
-  config = config.split('\n')
-      .slice(1)
-      .join('\n')
-      .replace(/"/g, '\\"')
-      .replace(/'/g, '"');
-
   process.config = JSON.parse(config, function(key, value) {
     if (value === 'true') return true;
     if (value === 'false') return false;

diff --git a/tools/js2c.py b/tools/js2c.py
@@ -292,6 +292,11 @@ def JS2C(source, target):
         split = split[1:]
       name = '/'.join(split)
 
+    # if its a gypi file we're going to want it as json
+    # later on anyway, so get it out of the way now
+    if name.endswith(".gypi"):
+      lines = re.sub(r'#.*?\n', '', lines)
+      lines = re.sub(r'\'', '"', lines)
     name = name.split('.', 1)[0]
     var = name.replace('-', '_').replace('/', '_')
     key = '%s_key' % var