doc: harden policy around objections

Harden policy around objections to avoid misunderstanding and to encourage collaboration between pull request authors and objectors. Fixes: #34564 PR-URL: #34639 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Aug 10, 2020 · 71aeea1 · 71aeea1
1 parent 0f4b4ea
commit 71aeea1
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/doc/guides/collaborator-guide.md b/doc/guides/collaborator-guide.md
@@ -120,14 +120,22 @@ needed [approvals](#code-reviews), [CI](#testing-and-ci), and
 except the [wait time](#waiting-for-approvals), please add the
 [`author ready`](#author-ready-pull-requests) label.
 
-Where there is disagreement among Collaborators, consensus should be sought if
-possible. If reaching consensus is not possible, a Collaborator may escalate the
-issue to the TSC.
-
-Collaborators should not block a pull request without providing a reason.
-Another Collaborator may ask an objecting Collaborator to explain their
-objection. If the objector is unresponsive, another Collaborator may dismiss the
-objection.
+If a collaborator believes a pull request should not land as is, **the "Request
+Changes" GitHub feature must be used to make the objection explicit**. An
+implicit objection not using the "Request Changes" feature is not a
+blocker for a pull request. Pull requests with an explicit objection should
+not land until all objections are satisfied. Collaborators should not block a
+pull request without providing a reason. **Providing a set of actionable steps
+alongside the objection is recommended, and the objector must be willing to
+work with the pull request author to reach a consensus about the direction of
+the pull request**. If reaching consensus is not possible, a Collaborator may
+escalate the issue to the TSC.
+
+If the objection is not clear to others, another Collaborator may ask an
+objecting Collaborator to explain their objection or to provide actionable
+steps to resolve the objection. **If the objector is unresponsive for seven
+days after a collaborator asks for clarification, another Collaborator may
+dismiss the objection**.
 
 [Breaking changes](#breaking-changes) must receive
 [TSC review](#involving-the-tsc). If two TSC members approve the pull request