Skip to content

Commit

Permalink
test: allow short benchmarks for tests
Browse files Browse the repository at this point in the history
Enable short benchmarks for process and path benchmark tests. These have
been observed to fail in CI due to returning with zero operations
performed in the allotted time. We have a special environment variable
for other benchmark tests that can be set to make that allowable in
benchmarks. Set it for path and process.

PR-URL: #16097
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
  • Loading branch information
Trott authored and targos committed Oct 18, 2017
1 parent cbbb229 commit 6dc3c11
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/parallel/test-benchmark-path.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ runBenchmark('path',
'pathext=',
'paths=',
'props='
]);
], { NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });
2 changes: 1 addition & 1 deletion test/parallel/test-benchmark-process.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ runBenchmark('process',
'millions=0.000001',
'n=1',
'type=raw'
]);
], { NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });

0 comments on commit 6dc3c11

Please sign in to comment.