Skip to content

Commit

Permalink
test,net: remove scatological terminology
Browse files Browse the repository at this point in the history
PR-URL: #16599
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
  • Loading branch information
Trott authored and cjihrig committed Nov 6, 2017
1 parent 1771bb5 commit 6998591
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ function afterShutdown(status, handle, req) {
// if the writable side has ended already, then clean everything
// up.
function onSocketEnd() {
// XXX Should not have to do as much crap in this function.
// XXX Should not have to do as much in this function.
// ended should already be true, since this is called *after*
// the EOF errno and onread has eof'ed
debug('onSocketEnd', this._readableState);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-wrap-uncaughtexception.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ process.on('uncaughtException', common.mustCall(() => {
require('crypto').randomBytes(1, common.mustCall(() => {
assert.strictEqual(call_id, async_hooks.executionAsyncId());
call_log[1]++;
throw new Error('ah crap');
throw new Error();
}));

1 comment on commit 6998591

@papiro
Copy link

@papiro papiro commented on 6998591 Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Please sign in to comment.