test: validate common property usage

`common` contains multiple 'check'(boolean) properties that will be false if mistyped and may lead to errors. This makes sure that the used property exists in the `common`. PR-URL: #31933 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Mar 30, 2020 · 67c3a95 · 67c3a95
1 parent 26d9f4c
commit 67c3a95
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/test/common/index.js b/test/common/index.js
@@ -739,7 +739,7 @@ function invalidArgTypeHelper(input) {
   return ` Received type ${typeof input} (${inspected})`;
 }
 
-module.exports = {
+const common = {
   allowGlobals,
   buildType,
   canCreateSymLink,
@@ -882,3 +882,12 @@ module.exports = {
   }
 
 };
+
+const validProperties = new Set(Object.keys(common));
+module.exports = new Proxy(common, {
+  get(obj, prop) {
+    if (!validProperties.has(prop))
+      throw new Error(`Using invalid common property: '${prop}'`);
+    return obj[prop];
+  }
+});