Skip to content

Commit

Permalink
cluster: fix fd leak
Browse files Browse the repository at this point in the history
  • Loading branch information
theanarkh committed Jul 4, 2022
1 parent a81b4eb commit 603c560
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/internal/cluster/child.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ function onconnection(message, handle) {

if (accepted)
server.onconnection(0, handle);
else
handle.close();
}

function send(message, cb) {
Expand Down
27 changes: 27 additions & 0 deletions test/parallel/test-cluster-worker-handle-close.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';
const common = require('../common');
const cluster = require('cluster');
const net = require('net');

if (cluster.isPrimary) {
cluster.schedulingPolicy = cluster.SCHED_RR;
cluster.fork();
} else {
const server = net.createServer(common.mustNotCall());
server.listen(0, common.mustCall(() => {
net.connect(server.address().port);
}));
process.prependListener('internalMessage', common.mustCallAtLeast((message, handle) => {
if (message.act !== 'newconn') {
return;
}
// Make the worker drops the connection, see `rr` and `onconnection` in child.js
server.close();
const close = handle.close;
handle.close = common.mustCall(() => {
close.call(handle, common.mustCall(() => {
process.exit();
}));
});
}));
}

0 comments on commit 603c560

Please sign in to comment.