src: don't run tasks on isolate termination

Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Nov 21, 2022 · 5e5bf0c · 5e5bf0c
1 parent 10e7c2a
commit 5e5bf0c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/node_platform.cc b/src/node_platform.cc
@@ -406,7 +406,7 @@ int NodePlatform::NumberOfWorkerThreads() {
 }
 
 void PerIsolatePlatformData::RunForegroundTask(std::unique_ptr<Task> task) {
-  if (isolate_->IsExecutionTerminating()) return task->Run();
+  if (isolate_->IsExecutionTerminating()) return;
   DebugSealHandleScope scope(isolate_);
   Environment* env = Environment::GetCurrent(isolate_);
   if (env != nullptr) {