events: use nullish coalencing operator

PR-URL: #38328 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · May 18, 2021 · 5b40e2f · 5b40e2f
1 parent 8590c15
commit 5b40e2f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/benchmark/events/ee-add-remove.js b/benchmark/events/ee-add-remove.js
@@ -1,16 +1,26 @@
 'use strict';
 const common = require('../common.js');
-const events = require('events');
+const { EventEmitter } = require('events');
 
-const bench = common.createBenchmark(main, { n: [1e6] });
+const bench = common.createBenchmark(main, {
+  newListener: [0, 1],
+  removeListener: [0, 1],
+  n: [1e6],
+});
 
-function main({ n }) {
-  const ee = new events.EventEmitter();
+function main({ newListener, removeListener, n }) {
+  const ee = new EventEmitter();
   const listeners = [];
 
   for (let k = 0; k < 10; k += 1)
     listeners.push(() => {});
 
+  if (newListener === 1)
+    ee.on('newListener', (event, listener) => {});
+
+  if (removeListener === 1)
+    ee.on('removeListener', (event, listener) => {});
+
   bench.start();
   for (let i = 0; i < n; i += 1) {
     const dummy = (i % 2 === 0) ? 'dummy0' : 'dummy1';

diff --git a/lib/events.js b/lib/events.js
@@ -406,7 +406,7 @@ function _addListener(target, type, listener, prepend) {
     // adding it to the listeners, first emit "newListener".
     if (events.newListener !== undefined) {
       target.emit('newListener', type,
-                  listener.listener ? listener.listener : listener);
+                  listener.listener ?? listener);
 
       // Re-assign `events` because a newListener handler could have caused the
       // this._events to be assigned to a new object