Skip to content

Commit

Permalink
test: do not check text for engine-generated error
Browse files Browse the repository at this point in the history
In test-tls-wrap-event-emitter, the text of a TypeError is checked as
part of the test. However, this text is generated by the JavaScript
engine (V8) and not Node.js. Thus, we should not check the text as JS
engine error messages can change without it being considered a breaking
change for Node.js.

A side effect is that node-chakracore will no longer need to patch this
test to pass.

PR-URL: #19215
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
Trott authored and targos committed Mar 17, 2018
1 parent 3e4e0ad commit 50af61f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/parallel/test-tls-wrap-event-emmiter.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ const TlsSocket = require('tls').TLSSocket;
const EventEmitter = require('events').EventEmitter;
assert.throws(
() => { new TlsSocket(new EventEmitter()); },
/^TypeError: (.+) is not a function$/
TypeError
);

0 comments on commit 50af61f

Please sign in to comment.