tools: make comma-dangle ESLint rule more stringent …

We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: #37088 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Feb 28, 2021 · 49013fc · 49013fc
1 parent 6205e29
commit 49013fc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -95,7 +95,13 @@ module.exports = {
         ignorePattern: '.*',
       },
     }],
-    'comma-dangle': ['error', 'only-multiline'],
+    'comma-dangle': ['error', {
+      arrays: 'always-multiline',
+      exports: 'only-multiline',
+      functions: 'only-multiline',
+      imports: 'only-multiline',
+      objects: 'only-multiline',
+    }],
     'comma-spacing': 'error',
     'comma-style': 'error',
     'computed-property-spacing': 'error',

diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml
@@ -5,6 +5,8 @@ env:
   es6: true
 
 rules:
+  # For now, comma-dangle is more lenient in the test directory than elsewhere.
+  comma-dangle: ["error", "only-multiline"]
   no-var: error
   prefer-const: error
   symbol-description: off