-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
url: handle quasi-WHATWG URLs in urlToOptions()
Backport-PR-URL: #32444
- Loading branch information
Showing
2 changed files
with
21 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -133,8 +133,8 @@ assert.strictEqual(url.searchParams, oldParams); | |
|
||
// Test urlToOptions | ||
{ | ||
const opts = | ||
urlToOptions(new URL('http://user:[email protected]:21/aaa/zzz?l=24#test')); | ||
const urlObj = new URL('http://user:[email protected]:21/aaa/zzz?l=24#test'); | ||
const opts = urlToOptions(urlObj); | ||
assert.strictEqual(opts instanceof URL, false); | ||
assert.strictEqual(opts.protocol, 'http:'); | ||
assert.strictEqual(opts.auth, 'user:pass'); | ||
|
@@ -147,6 +147,23 @@ assert.strictEqual(url.searchParams, oldParams); | |
|
||
const { hostname } = urlToOptions(new URL('http://[::1]:21')); | ||
assert.strictEqual(hostname, '::1'); | ||
|
||
// If a WHATWG URL object is copied, it is possible that the resulting copy | ||
// contains the Symbols that Node uses for brand checking, but not the data | ||
// properties, which are getters. Verify that urlToOptions() can handle such | ||
// a case. | ||
const copiedUrlObj = Object.assign({}, urlObj); | ||
const copiedOpts = urlToOptions(copiedUrlObj); | ||
assert.strictEqual(copiedOpts instanceof URL, false); | ||
assert.strictEqual(copiedOpts.protocol, undefined); | ||
assert.strictEqual(copiedOpts.auth, undefined); | ||
assert.strictEqual(copiedOpts.hostname, undefined); | ||
assert.strictEqual(copiedOpts.port, NaN); | ||
assert.strictEqual(copiedOpts.path, ''); | ||
assert.strictEqual(copiedOpts.pathname, undefined); | ||
assert.strictEqual(copiedOpts.search, undefined); | ||
assert.strictEqual(copiedOpts.hash, undefined); | ||
assert.strictEqual(copiedOpts.href, undefined); | ||
} | ||
|
||
// Test special origins | ||
|